Remove redundant buffer in UIScene_SettingsGraphicsMenu.cpp#1380
Merged
mattsumi merged 1 commit intosmartcmd:mainfrom Mar 22, 2026
Merged
Remove redundant buffer in UIScene_SettingsGraphicsMenu.cpp#1380mattsumi merged 1 commit intosmartcmd:mainfrom
mattsumi merged 1 commit intosmartcmd:mainfrom
Conversation
Collaborator
|
Thank you for contributing! |
itsRevela
added a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
…#1348) (smartcmd#1380) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
itsRevela
added a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
itsRevela
pushed a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removes a redudant buffer in handleSliderMove for the FOV slider, use existing tempstring
Changes
Previous Behavior
eControl_FOV case declared its own tempString
Root Cause
when this was added, whoever made the slider case decided to make it use their own tempstring instead of the existing one
Fix Implementation
remove the redundant tempstring declaration and use the existing TempString instead
AI Use Disclosure
no ai
Related Issues